Switched Datetime format for <environment_details> to something clearer (ISO) #2353
Conversation
|
dosubot
bot
added
size:S
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| const offsetMinutes = pad(tzOffset % 60) | ||
|
|
||
| // Remove the trailing 'Z' from ISO string and add the custom offset | ||
| const isoWithoutZ = now.toISOString().replace("Z", "") |
There was a problem hiding this comment.
The new implementation for formatting the current time is problematic: it uses now.toISOString() (which always returns a UTC timestamp) and then simply removes the trailing 'Z' and appends the local timezone offset. This does not convert the time portion to local time. For example, in a timezone of UTC+01:00, if the real local time is 12:00, toISOString() might yield 11:00Z, and the result becomes "11:00+01:00" instead of the correct local time 12:00. Consider converting the date to local values (using native Date methods or a date library) before formatting, so the time and offset are consistent. This issue should be fixed to reliably display the correct local time.
|
Actually flawed. closing this for now - sending a new one. |
github-project-automation
bot
moved this from PR [Pre Approval Review]
to Done
in Roo Code Roadmap
1 participant
Context
The datetime format for <environment_details> was weird and had the potential to confuse LLMs.
For example it used an international date format that was not defined and fell back to local. In my case (German) todays date output was 6.4.2025 which got confused by LLM for June 4th multiple times (instead of April 6th).
The forced time format of 12h which is completely not used in germany probably added to that confusion.
Implementation
I changed the date format to a proper ISO format including the timezone offset to keep the local relation.
Get in Touch
@Helmi on discord.
Important
Changed datetime format in
Cline.tsto ISO with timezone offset for clarity ingetEnvironmentDetails().Cline.ts, changed datetime format to ISO with timezone offset ingetEnvironmentDetails().toISOString()and manual timezone offset calculation.This description was created by
for d0c725a. It will automatically update as commits are pushed.